Re: [[PATCHv2] 3/3] drivers/rtc/rtc-snvs: Add clock support

[Shawn Guo]

On Thu, Nov 13, 2014 at 11:03:09AM +0530, Sanchayan Maity wrote:
> On Wednesday 12 November 2014 04:17 PM, Shawn Guo wrote:
> > On Wed, Nov 12, 2014 at 02:26:51PM +0530, Sanchayan Maity wrote:
> >> On Wednesday 12 November 2014 02:57 AM, Stefan Agner wrote:
> >>> On 2014-11-07 14:04, Sanchayan Maity wrote:
> >>>> This patch adds clock enable and disable support for
> >>>> the SNVS peripheral, which is required for using the
> >>>> RTC within the SNVS block.
> >>>
> >>> What happens if the device tree node is there while this patch is not
> >>> applied? I guess the driver would load, but since the clocks of the
> >>> peripheral are not enabled the first register access would lead to bus
> >>> error or similar. If this is the case, this would break bisectability.
> >>> You should move the device tree patch to the end.
> >>>
> >>
> >> If the DT node was present with this patch not applied, the driver would 
> >> still crash with a bus error, since the clocks for SNVS are not explicitly 
> >> enabled anywhere else. I had not thought about any problems which might 
> >> occur later with git bisect. Will move this to the end with v3.
> > 
> > Since changes on rtc-snvs.c will need to go through RTC subsystem tree,
> > that means I cannot apply DTS changes until the driver patch gets
> > mainlined and appears on my tree.
> > 
> > Shawn
> 
> Shawn
> 
> So the approach in this patch is OK and acceptable? 

Yes, I'm fine with it.

Shawn

> 
> Since the DT changes cannot be applied by you, till this goes through the 
> RTC subsystem tree, gets mainlined and appears on your tree, I will send out 
> this patch by itself then and send the DT changes later once this gets
> mainlined?
> 
> I did not CC Alessandro Zummo, the maintainer of RTC subsystem by mistake.
> Once you ACK/OK this i will send out this patch in isolation then or just 
> CC Alessandro Zummo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/