RE: [PATCH v4] ARM: EXYNOS: add Exynos3250 PMU support

[Pankaj Dubey]

On Tuesday, November 18, 2014 11:05 PM, Bartlomiej Zolnierkiewicz Wrote:
> This patch prepares the PMU code for the future:
> - suspend/resume (S2R) support
> - cpuidle AFTR/W-AFTR modes support
> on Exynos3250.
> 
> Cc: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
> Cc: Vikas Sajjan <vikas.sajjan@xxxxxxxxxxx>
> Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>

Other than one small nitpick patch looks fine to me. Tested on Exynos3250
based
Espresso board and kernel booted fine.

Reviewed-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>

> 
> +static void exynos3250_pmu_init(void)
> +{
> +	unsigned int value;
> +
> +	/*
> +	 * To prevent form issuing new bus request form L2 memory system

typo: %s/form/from

> +	 * If core status is power down, should be set '1' to L2 power down
> +	 */

Thanks,
Pankaj Dubey

> --
> 1.8.2.3


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/