Re: [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map

[Murali Karicheri]

On 11/14/2014 05:19 PM, Dmitry Torokhov wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov<dtor@xxxxxxxxxxxx>
> ---
>
> Not tested, found by casual code inspection.
>
>   drivers/pci/host/pci-keystone.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
> index 8a27078..f2bd48d 100644
> --- a/drivers/pci/host/pci-keystone.c
> +++ b/drivers/pci/host/pci-keystone.c
> @@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie,
>   	 */
>   	for (temp = 0; temp<  max_host_irqs; temp++) {
>   		host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);
> -		if (host_irqs[temp]<  0)
> +		if (!host_irqs[temp])
>   			break;
>   	}
>   	if (temp) {
Good catch!

Acked-By: Murali Karicheri <m-karicheri2@xxxxxx>

--
Murali Karicheri
Linux Kernel, Texas Instruments
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/