v3.18-rc5 build failure on ppc64 in Documentation/mic/mpssd/mpssd.o

[Seth Jennings]

One or more in the following commit set in the 3.18 merge window is causing
build failure on ppc64 with the default config:

7b345771ba921361b318e95bf21b257c65ac141c Documentation: update include path for mpssd
8c2b0dc83d9840da4d993a5dbb15c5974ad5a188 Documentation: support glibc versions without htole macros
6ab0e475f1f38b6be90aff4ef3ebf928c4a73dc8 Documentation: fix misc. warnings
adb19fb66eeebac07fe37d968725bb8906dadb8e Documentation: add makefiles for more targets

Building v3.18-rc5 and I have glibc 2.17.

The problem is that for big endian, the htole* macros are not simple compile
time transforms by the precompiler, but rather block code that must be executed
in function context.

Build errors:
===
  HOSTCC  Documentation/mic/mpssd/mpssd.o
In file included from /usr/include/bits/byteswap.h:34:0,
                 from /usr/include/endian.h:60,
                 from /usr/include/bits/waitstatus.h:64,
                 from /usr/include/stdlib.h:42,
                 from Documentation/mic/mpssd/mpssd.c:23:
Documentation/mic/mpssd/mpssd.c:93:10: error: braced-group within expression allowed only inside a function
   .num = htole16(MIC_VRING_ENTRIES),
          ^
Documentation/mic/mpssd/mpssd.c:96:10: error: braced-group within expression allowed only inside a function
   .num = htole16(MIC_VRING_ENTRIES),
          ^
Documentation/mic/mpssd/mpssd.c:113:10: error: braced-group within expression allowed only inside a function
   .num = htole16(MIC_VRING_ENTRIES),
          ^
Documentation/mic/mpssd/mpssd.c:116:10: error: braced-group within expression allowed only inside a function
   .num = htole16(MIC_VRING_ENTRIES),
          ^
Documentation/mic/mpssd/mpssd.c:119:3: error: initializer element is not constant
   .host_features = htole32(
   ^
Documentation/mic/mpssd/mpssd.c:119:3: error: (near initialization for âvirtnet_dev_page.host_featuresâ)
In file included from /usr/include/bits/byteswap.h:34:0,
                 from /usr/include/endian.h:60,
                 from /usr/include/bits/waitstatus.h:64,
                 from /usr/include/stdlib.h:42,
                 from Documentation/mic/mpssd/mpssd.c:23:
Documentation/mic/mpssd/mpssd.c:146:10: error: braced-group within expression allowed only inside a function
   .num = htole16(MIC_VRING_ENTRIES),
          ^
Documentation/mic/mpssd/mpssd.c:149:3: error: initializer element is not constant
   htole32(1<<VIRTIO_BLK_F_SEG_MAX),
   ^
Documentation/mic/mpssd/mpssd.c:149:3: error: (near initialization for âvirtblk_dev_page.host_featuresâ)
Documentation/mic/mpssd/mpssd.c:151:3: error: initializer element is not constant
   .seg_max = htole32(MIC_VRING_ENTRIES - 2),
   ^
Documentation/mic/mpssd/mpssd.c:151:3: error: (near initialization for âvirtblk_dev_page.blk_config.seg_maxâ)
Documentation/mic/mpssd/mpssd.c:152:3: error: initializer element is not constant
   .capacity = htole64(0),
   ^
Documentation/mic/mpssd/mpssd.c:152:3: error: (near initialization for âvirtblk_dev_page.blk_config.capacityâ)
make[3]: *** [Documentation/mic/mpssd/mpssd.o] Error 1
===

Reverting the commits fixes the issue, however, a more targeted approach could
just skip make on Documentation/mic/mpssd/ until the endianness issue is
resolved. Or something else...

Thanks,
Seth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/