Re: [PATCHv5 1/1] thermal: of: improve of-thermal sensor registration API

[Guenter Roeck]

On 11/20/2014 06:18 AM, Eduardo Valentin wrote:
> Hi Guenter,
>
> On Thu, Nov 20, 2014 at 10:12:13AM -0400, Eduardo Valentin wrote:
> > Different drivers request API extensions in of-thermal. For this reason,
> > additional callbacks are required to fit the new drivers needs.
> >
> > The current API implementation expects the registering sensor driver
> > to provide a get_temp and get_trend callbacks as function parameters.
> > As the amount of callbacks is growing, this patch changes the existing
> > implementation to use a .ops field to hold all the of thermal callbacks
> > to sensor drivers.
> >
> > This patch also changes the existing of-thermal users to fit the new
> > API design. No functional change is introduced in this patch.
> >
> > Cc: Alexandre Courbot <gnurou@xxxxxxxxx>
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Cc: Grant Likely <grant.likely@xxxxxxxxxx>
> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Cc: Jean Delvare <jdelvare@xxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: linux-pm@xxxxxxxxxxxxxxx
> > Cc: linux-tegra@xxxxxxxxxxxxxxx
> > Cc: lm-sensors@xxxxxxxxxxxxxx
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> > Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> > Tested-by: Mikko Perttunen <mikko.perttunen@xxxxxxxx>
> > Reviewed-by: Mikko Perttunen <mikko.perttunen@xxxxxxxx>
> > Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> > Reviewed-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>
> > Signed-off-by: Eduardo Valentin <edubezval@xxxxxxxxx>
> > ---
> >   drivers/hwmon/lm75.c                               |  9 +++--
> >   drivers/hwmon/ntc_thermistor.c                     |  6 +++-
> >   drivers/hwmon/tmp102.c                             |  6 +++-
>
> Do you have objections if I queue this one for 3.19?

No.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/