[for-next][PATCH] tracing: Deletion of an unnecessary check before iput()

From: Steven Rostedt
Date: Thu Nov 20 2014 - 10:19:19 EST


Head SHA1: 16a8ef2751801346f1f76a18685b2beb63cd170f

Markus Elfring (1):
tracing: Deletion of an unnecessary check before iput()

kernel/trace/trace_uprobe.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
commit 16a8ef2751801346f1f76a18685b2beb63cd170f
Author: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun Nov 16 14:46:28 2014 +0100

tracing: Deletion of an unnecessary check before iput()

The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Link: http://lkml.kernel.org/r/5468F875.7080907@xxxxxxxxxxxxxxxxxxxxx

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index fd76f8e108ef..8520acc34b18 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -552,8 +552,7 @@ error:
return ret;

- if (inode)
- iput(inode);
+ iput(inode);

pr_info("Failed to parse address or file.\n");

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/