Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

From: Felipe Balbi
Date: Thu Nov 20 2014 - 14:51:11 EST

On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote:
> From: Ronald Wahl <ronald.wahl@xxxxxxxxxxx>
> Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gadget: at91_udc:
> prepare clk before calling enable) added clock preparation in interrupt
> context. This is not allowed as it might sleep. Also setting the clock
> rate is unsafe to call from there for the same reason. Move clock
> preparation and setting clock rate into process context (at91udc_probe).
> Signed-off-by: Ronald Wahl <ronald.wahl@xxxxxxxxxxx>
> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v3.17+
> ---
> Hi Felipe,
> I forgot to answer you on this patch. So I resend it now with the proper
> "stable" tag. You can also queue it during this -rc phase if you feel it is
> still possible.

I think it's late for v3.18, so it'll go on v3.19 and get backported to
3.17 and 3.18. Sorry :-s



Attachment: signature.asc
Description: Digital signature