Re: linux-next: build failure after merge of the ftrace tree

[Jiri Kosina]

On Fri, 21 Nov 2014, Steven Rostedt wrote:

> > From: Jiri Kosina <jkosina@xxxxxxx>
> > Subject: [PATCH] printk: make sure printk_func_t is known in percpu.h
> > 
> > Commit afdc34a3d3b8 ("printk: Add per_cpu printk func to allow printk to 
> > be diverted") caused percpu variable printk_func to be declared in 
> > percpu.h. Make sure that the corresponding type is known at the time of 
> > declaration.
> > 
> > Fixes build failure on certain arch/config combinations.
> > 
> > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
> > ---
> >  include/linux/percpu.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/percpu.h b/include/linux/percpu.h
> > index a3aa63e..c94c766 100644
> > --- a/include/linux/percpu.h
> > +++ b/include/linux/percpu.h
> > @@ -7,6 +7,7 @@
> >  #include <linux/cpumask.h>
> >  #include <linux/pfn.h>
> >  #include <linux/init.h>
> > +#include <linux/printk.h>
> >  
> >  #include <asm/percpu.h>
> 
> Unfortunately, this wasn't the fix. This was an allnoconfig, which
> means printk wasn't defined.

Ah, thanks, that indeed needs to be done as well.

I still think that the patch I sent should be applied, as there might be 
configurations where printk.h doesn't implicitly transitively make it into 
percpu.h.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/