RE: [PATCH] sb_edac: Add support for Broadwell-DE processor

[Luck, Tony]

>> +	{ PCI_DESCR(PCI_DEVICE_ID_INTEL_BROADWELL_IMC_HA0_TAD2, 1)	},
>> +	{ PCI_DESCR(PCI_DEVICE_ID_INTEL_BROADWELL_IMC_HA0_TAD3, 1)	},
>
> You are marking TAD2 and TAD3 as optional here, but
>
>> +	for (i = 0; i < NUM_CHANNELS; i++) {
>> +		if (!pvt->pci_tad[i])
>> +			goto enodev;
>> +	}
>
> It's not optional here.

Heh. Cut & paste from the HASWELL version which has the same issue.
So we need to fix there too.

Thanks for the review.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/