Re: [GIT PULL] ftrace/x86: Add frames pointers to trampoline as necessary

[Linus Torvalds]

On Fri, Nov 21, 2014 at 6:50 AM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> +.macro create_frame parent rip
> +#ifdef CC_USING_FENTRY
> +       pushq \parent
> +       pushq %rbp
> +       movq %rsp, %rbp

This is a very strange frame.

Why do you do the "pushq \parent" at all? Why isn't this just a *real*
frame and add it to MCOUNT_SAVE_FRAME.

You seem to create this fake frame-within-a-frame thing. It's not clear why.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/