Re: [PATCH] dell-smo8800: Add more acpi ids and change description of driver

[Pali RohÃr]

Oops, I lost this mail somewhere...

I copied these ids from windows driver inf file. I did not tested 
them because I do not have machine which reports these ids. It 
looks like all SMOXX devices have same acpi structure (one IRQ). 
So adding ids could not break anything (if acpi device will not 
have for some reason IRQ specified, device probe function will 
fail).

On Monday 29 September 2014 22:56:04 Darren Hart wrote:
> On Mon, Sep 29, 2014 at 02:45:48PM +0200, Pali RohÃr wrote:
> 
> Please see Documentation/SubmittingPatches, 15) The canonical
> patch format, and provide a complete message body.
> 
> Have you validated each of the 6 ACPI IDs added to the driver?
> 
> > Signed-off-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
> > ---
> > 
> >  drivers/platform/x86/Kconfig        |    4 ++--
> >  drivers/platform/x86/dell-smo8800.c |   10 ++++++++--
> >  2 files changed, 10 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 3bbcbf1..ba9ee4f
> > 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -128,10 +128,10 @@ config DELL_WMI_AIO
> > 
> >  	  be called dell-wmi-aio.
> >  
> >  config DELL_SMO8800
> > 
> > -	tristate "Dell Latitude freefall driver (ACPI
> > SMO8800/SMO8810)" +	tristate "Dell Latitude freefall driver
> > (ACPI SMO88XX)"
> > 
> >  	depends on ACPI
> >  	---help---
> > 
> > -	  Say Y here if you want to support SMO8800/SMO8810
> > freefall device +	  Say Y here if you want to support
> > SMO88XX freefall device
> 
> "devices" now that multiple are supported.
> 
> Thanks,

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.