RE: [PATCH] acpi:apd:add AMD ACPI2Platform device support for x86 system.
From: Xue, Ken
Date: Sun Nov 23 2014 - 21:36:03 EST
On Tuesday, November 18, 2014 01:58:11 PM Ken Xue wrote:
> This new feature is to interpret AMD specific ACPI device to platform
> device such as I2C, UART found on AMD CZ and later chipsets. It is
> based on example INTEL LPSS. Now, it can support AMD I2C & UART.
> Signed-off-by: Ken Xue <Ken.Xue@xxxxxxx>
> Signed-off-by: Jeff Wu <Jeff.Wu@xxxxxxx>
Generally speaking, this seems to duplicate much code from acpi_lpss which should be re-used instead. What about moving the code that will be common between acpi_lpss and the new driver into a new file (say acpi_soc.c)?
Also, you need to avoid automatic creation of platform devices when !X86_AMD_PLATFORM_DEVICE in analogy with what acpi_lpss does, or bad things will happen.
[ken] sounds fair enough. Let me take action to merge drivers to acpi_soc.c ? or you have other plan?