RE: [PATCH v11 00/19] input: cyapa: instruction of cyapa patches

From: Dudley Du
Date: Sun Nov 23 2014 - 22:06:27 EST


Jeremiah,

Thank you very much for your information.
I will look into this issue.
Could you send me the system log if possible when you encounter this issue.

Thanks
Dudley

> -----Original Message-----
> From: Jeremiah Mahler [mailto:jmmahler@xxxxxxxxx]
> Sent: 2014?11?21? 16:56
> To: Dudley Du
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v11 00/19] input: cyapa: instruction of cyapa patches
>
> Dudley,
>
> On Wed, Nov 19, 2014 at 04:37:32PM +0800, Dudley Du wrote:
> > V11 patches have below main updates compared with v10 patches:
> > 1) Add add acpi device id supported for old gen3 and new gen5 trackpad
devices.
> > 2) Fix the unable to update firmware issue when cyapa_open is not called
> > which means the irq for firwmare update process is not enabled. This fix
> []
>
> I am having a problem with an older patch which is currently in
> linux-next (20141120) and which might be related to this new patch set.
>
> On an Acer C720 if a suspend and resume is performed the touchpad will
> stop working. If the cyapa driver is reloaded it will begin working
> again.
>
> I performed a bisect and found that the following patch was the cause.
>
> From b1cfa7b4388285c0f0b486f152ab0cb18612c779 Mon Sep 17 00:00:00 2001
> From: Dudley Du <dudley.dulixin@xxxxxxxxx>
> Date: Sun, 9 Nov 2014 12:36:34 -0800
> Subject: [PATCH] Input: cyapa - switch to using managed resources
>
> Use of managed resources simplifies error handling and device removal
> code.
>
> Signed-off-by: Dudley Du <dudl@xxxxxxxxxxx>
> [Dmitry: added open/close methods so cyapa_remove is no longer needed.]
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>
> If I can provide any other information that would be of help let me know.
> I will try out your new patchset if I get a chance.
>
> --
> - Jeremiah Mahler

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/