Re: Implement lbr-as-callgraph v10

[Namhyung Kim]

Hi Andi and Arnaldo,

On Sat, 22 Nov 2014 02:25:19 +0100, Andi Kleen wrote:
>>      f1 tcall.c:9
>>      main tcall.c:17
>>      main tcall.c:17
>>      main tcall.c:16
>>      main tcall.c:16
>>      f1 tcall.c:12
>>      f1 tcall.c:12
>>      f2 tcall.c:6
>>      f2 tcall.c:4
>>      f1 tcall.c:11
>>      f1 tcall.c:11
>>      f2 tcall.c:6
>>      f2 tcall.c:4
>>      f1 tcall.c:10
>>      f1 tcall.c:9
>>      main tcall.c:17
>> <SNIP>
>> 
>> 
>> Do you see the diff?  The 87.65% and 12.35% doesn't appear on the --tui
>> output.
>
> I see the problem. It's some issue in hist_browser__show_callchain.
> --stdio doesn't show it because it doesn't seem to use that (?)
>
> With this patch it shows percent for the first entry
>
> @@ -791,7 +791,7 @@ static int hist_browser__show_entry(struct hist_browser *browser,
>                 };
>  
>                 printed += hist_browser__show_callchain(browser,
> -                                       &entry->sorted_chain, 1, row, total,
> +                                       &entry->sorted_chain, 2, row, total,
>                                         hist_browser__show_callchain_entry, &arg,
>                                         hist_browser__check_output_full);
>
> But the numbers are still different from what --stdio outputs,
> so there are some deeper issues.
>
> I doubt I caused this, probably some latent bug that just got triggered.
>
> Namhyung?

I think it's an old bug even before my callchain cleanup patch series.
It only prints percent if the level is greater than 1 which I guess it
assumes there's only a single callchain path for the first level.

I'll post a patch for that soon.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/