RE: [PATCH v8 1/2] procfs: show hierarchy of pid namespace

[Chen, Hanxiao]

> -----Original Message-----
> From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx]
> Sent: Friday, November 21, 2014 6:21 AM
> To: Richard Weinberger
> Cc: Chen, Hanxiao/陈 晗霄; Eric W. Biederman; Serge Hallyn; Oleg Nesterov;
> containers@xxxxxxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Mateusz
> Guzik; David Howells
> Subject: Re: [PATCH v8 1/2] procfs: show hierarchy of pid namespace
> 
> On Thu, 20 Nov 2014 22:29:42 +0100 Richard Weinberger <richard@xxxxxx> wrote:
> 
> > >
> > > Any comments?
> >
> > FWIW, Acked-by: Richard Weinberer <richard@xxxxxx>
> >
> > The more challenging question is who will pickup this series?
> > Eric? Andrew?
> 
> I can monkey the patches but I'd very much like to hear Eric's comments.
> 
> Also the CRIU people.  How is CRIU presently reassembling these
> relationships?
> 
> Serge, what was your take on the usefulness/applicability of this work?
> IOW, why the ack?

Thanks for your attention and help.

I'd very much like to hear Eric's comments on this patch too.

Hi, Pavel, could you please provide some ideas from the CRIU's point of view?

> 
> The patchset doesn't touch Documentation/.  That will need to be fixed,
> please.  The new interfaces should be completely described in the
> kernel documentation.

I'll add a documentation patch soon.

> 
> The new code appears to be included when CONFIG_PID_NS=n.  Is there any
> point in doing that?

That code should not be included when CONFIG_PID_NS=n.

Thanks,
- Chen