Re: [PATCH v4 6/7] iio: dummy: Demonstrate the usage of new channel types

[Daniel Baluta]

On Sat, Nov 22, 2014 at 1:18 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On 22/11/14 11:05, Jonathan Cameron wrote:
>> On 10/11/14 12:45, Daniel Baluta wrote:
>>> Adds support for the new channel types in the dummy driver:
>>>   * a new channel IIO_ACTIVITY
>>>   * two state transition events (running and walking)
>>>   * a new channel IIO_STEPS and support for reading and writing
>>>     pedometer step counter
>>>   * step detect event
>>>   * a new IIO_CHAN_INFO_CALIBHEIGHT mask bit for reading and writing
>>>     user's height.
>>>
>>> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>
>>> Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxxxx>
>> The only bit that makes me wonder in here is allowing writing to the steps
>> and activity _input attributes.
>>
>> Now I can see that it makes sense from the point of view of testing the
>> interface and any userspace code, but the question here is whether the
>> 'normal IIO intefaces' of this dummy driver should correspond to real sensors
>> where writing to input channels isn't ever valid!.
>>
>> The alternative would be to create some deliberately not standard ABI for
>> these with a suitably obvious, 'I don't normally exist' naming - which
>> would then need documenting.  Perhaps what you have is the best option.
>> Pitty there isn't an out_steps_* interface.  Human interface control :)
>> Or even better out_activity_run_* which would be fun...
>>
>> Upshot is - leave this be.  It's our dummy driver afterall and we can
>> change the ABI as much as we like without anyone having a valid argument
>> that we broke their system ;)
>
> Applied to the togreg branch of iio.git - initially pushed out as testing.
>
> Nicely done with cc'ing a miss-spelt version of your own email address ;)

:)), I noticed that when was already too late.

Jonathan, Hartmut thanks for reviews!

Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/