Re: [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c

[SÃren Brinkmann]

On Mon, 2014-11-24 at 08:31PM +0100, Michal Simek wrote:
> On 11/24/2014 08:25 PM, Nicholas Krause wrote:
> > Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH
> > due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits
> > of the bus width and not just the lower or higher 16 depending on the machine's bit
> > order.
> > 
> > Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
> > ---
> >  drivers/block/xsysace.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
> > index c4328d9..1b807ed 100644
> > --- a/drivers/block/xsysace.c
> > +++ b/drivers/block/xsysace.c
> > @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)
> >  static int ace_probe(struct platform_device *dev)
> >  {
> >  	resource_size_t physaddr = 0;
> > -	int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */
> > +	int bus_width = ACE_BUS_WIDTH_16;
> >  	u32 id = dev->id;
> >  	int irq = 0;
> >  	int i;
> > 
> 
> Reviewed-by: Michal Simek <michal.simek@xxxxxxxxxx>

I find the commit message rather misleading, but the change is OK.

	SÃren
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/