Re: [PATCH v4 07/42] virtio_config: endian conversion for v1.0

[Cornelia Huck]

On Tue, 25 Nov 2014 23:36:14 +0200
"Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:

> On Tue, Nov 25, 2014 at 06:45:57PM +0100, Cornelia Huck wrote:
> > On Tue, 25 Nov 2014 18:41:52 +0200
> > "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
> > 
> > > We (ab)use virtio conversion functions for device-specific
> > > config space accesses.
> > > 
> > > Reviewed-by: David Hildenbrand <dahi@xxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
> > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > 
> > This looks odd with the various sign-offs but you as author...
> 
> Signoff tracks all contributors for developer's certificate
> of origin purposes.
> 
> Looking at the patch itself, not a single line (except the subject) seems
> to be shared with the original patch by Rusty that was posted with the
> same subject, so I guess I could have dropped them here, but as I
> refactor code I usually keep all signoffs around as a matter of policy.
> 
> Would you like yours to be dropped then?

Yes, I don't think it really makes sense anymore, as there's no code
left.

I also think David's r-b does not apply anymore, does it?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/