Re: [RFC PATCH] fs/binfmt_elf.c: fix inconsistent vma dump size

[Jungseung Lee]

2014-11-26 21:43 GMT+09:00 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:
> On Wed, 26 Nov 2014 21:37:54 +0900 Jungseung Lee <js07.lee@xxxxxxxxx> wrote:
>
>> 2014-11-26 15:51 GMT+09:00 Jungseung Lee <js07.lee@xxxxxxxxx>:
>>
>> >>> @@ -2093,7 +2083,20 @@ static int elf_core_dump(struct coredump_params *cprm)
>> >>>
>> >>>       dataoff = offset = roundup(offset, ELF_EXEC_PAGESIZE);
>> >>>
>> >>> -     offset += elf_core_vma_data_size(gate_vma, cprm->mm_flags);
>> >>> +     vma_filesz = kmalloc(sizeof(*vma_filesz) * (segs - 1), GFP_KERNEL);
>> >>
>> >> Use kmalloc_array() here, in case a disaster has occurred...
>> >>
>> > I'll try to find another way how to pass or save vma size with consistency.
>> >
>> it looks like just to replace kmalloc to vmalloc could be solution.
>> I'll send patch, thanks.
>
> Solution to what?  I was merely suggesting the use of kmalloc_array()
> instead of open-coded kmalloc(n * m).
>
Ah.. I misunderstood with my poor english. Thanks for the notice to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/