Re: [PATCH v4 38/42] virtio_scsi: v1.0 support

[Cornelia Huck]

On Tue, 25 Nov 2014 18:44:08 +0200
"Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:

> Note: for consistency, and to avoid sparse errors,
>   convert all fields, even those no longer in use
>   for virtio v1.0.
> 
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
>  include/linux/virtio_scsi.h | 32 +++++++++++++++-------------
>  drivers/scsi/virtio_scsi.c  | 51 ++++++++++++++++++++++++++++-----------------
>  2 files changed, 49 insertions(+), 34 deletions(-)
> 

> @@ -158,7 +158,7 @@ static void virtscsi_complete_cmd(struct virtio_scsi *vscsi, void *buf)
>  		sc, resp->response, resp->status, resp->sense_len);
> 
>  	sc->result = resp->status;
> -	virtscsi_compute_resid(sc, resp->resid);
> +	virtscsi_compute_resid(sc, __virtio32_to_cpu(vscsi->vdev, resp->resid));

Confused. Don't you need the non-underscore versions if you pass in a
vdev as first parameter?

>  	switch (resp->response) {
>  	case VIRTIO_SCSI_S_OK:
>  		set_host_byte(sc, DID_OK);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/