Re: perf/x86/intel/uncore: Add Haswell-EP uncore support

From: Dave Jones
Date: Wed Nov 26 2014 - 10:27:25 EST


On Wed, Nov 26, 2014 at 06:14:22AM -0800, Andi Kleen wrote:
> > I couldn't quickly decipher which MSRs we're writing to here in the SDM,
> > but are these really 64-bit wide registers that need 32 bits always set to zero ?
>
> Yes the filter MSRs are only 32bit.

thanks for checking.

> > I'm wondering if these should be just wrmsr's instead of wrmsrl's.
>
> Can we just shut up coverity please?

I can manually dismiss them, I don't think the checker has the
information to determine this for itself.

Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/