Re: [alsa-devel][PATCH] ASoC: wm8960: LRCM operation should after software reset

From: Mark Brown
Date: Wed Nov 26 2014 - 11:38:19 EST


On Wed, Nov 26, 2014 at 12:33:10PM +0100, Lars-Peter Clausen wrote:
> On 11/26/2014 12:02 PM, Zidan Wang wrote:
> >When shared_lrclk is set, LRCM will be enabled. But the following software
> >reset in wm8960_probe will reset it to the default state. So LRCM operation
> >should after software reset.

> It's probably a better idea to move the reset (together with the other
> register updates) to the I2C driver probe.

Yes, this is not a good fix.

Attachment: signature.asc
Description: Digital signature