Re: [RFC 2/2] kvm: eventfd: detect integer overflow using check_*_overflow

[Andrey Ryabinin]

2014-11-26 17:00 GMT+03:00 Sasha Levin <sasha.levin@xxxxxxxxxx>:
> Detect integer overflows using safe operations rather than relying on
> undefined behaviour.
>

Unsigned overflow is defined.
args->addr and args->len  both unsigned, so there is no UB here.

> Signed-off-by: Sasha Levin <sasha.levin@xxxxxxxxxx>
> ---
>  virt/kvm/eventfd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
> index 148b239..2eb044f 100644
> --- a/virt/kvm/eventfd.c
> +++ b/virt/kvm/eventfd.c
> @@ -790,7 +790,7 @@ kvm_assign_ioeventfd(struct kvm *kvm, struct kvm_ioeventfd *args)
>         }
>
>         /* check for range overflow */
> -       if (args->addr + args->len < args->addr)
> +       if (check_add_overflow(args->len, args->addr))
>                 return -EINVAL;
>
>         /* check for extra flags that we don't understand */
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/