Re: [PATCH RFC 2/2] mm, sched: trigger might_sleep() in might_fault() when pagefaults are disabled

[Michael S. Tsirkin]

On Thu, Nov 27, 2014 at 07:08:42PM +0100, David Hildenbrand wrote:
> > > > -
> > > > -	__might_sleep(__FILE__, __LINE__, 0);
> > > > +	if (unlikely(!pagefault_disabled()))
> > > > +		__might_sleep(__FILE__, __LINE__, 0);
> > > >    
> > 
> > Same here: so maybe make might_fault a wrapper
> > around __might_fault as well.
> 
> Yes, I also noticed that. It was part of the original code.
> For now I kept this revert as close as possible to
> the original patch.
> 
> Better fix this in an add-on patch? Or directly in this commit?

IMHO it's up to you really.

> At least for
> the in-header function it is easy to fix in this patch.
> 
> Thanks!

Right.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/