Re: [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property

From: Mark Brown
Date: Fri Nov 28 2014 - 06:22:09 EST


On Fri, Nov 28, 2014 at 10:09:44AM +0100, Krzysztof Kozlowski wrote:

> I understand your concerns here however I didn't want to overengineer
> this. Is the same GPIO (on more complex PMICs) used in different
> contexts? Like enable control and something more in the same time?

Yes, and it's often reprogrammable at runtime.

> Something like:
> struct regulator_desc desc {
> .name = "LDO1
> .of_match = of_match_ptr("LDO1"),
> .regulators_node = of_match_ptr("voltage-regulators"),
> .ops = &max77686_ldo_ops,
> + .of_ena_gpio = of_match_ptr("ena-gpios"),
> ...
> }

Yes, and note that this also means existing bindings can use the core
code.

Attachment: signature.asc
Description: Digital signature