Re: [PATCH 2/2] ARM: imx: src: support vf610 system reset controller

[Stefan Agner]

On 2014-11-28 17:49, Arnd Bergmann wrote:
> On Friday 28 November 2014 17:43:35 Stefan Agner wrote:
>> Support Vybrid SoC's system reset controller (SRC). Currently we
>> don't register a reset controller but only support the imx_cpu_jump
>> and imx_cpu_arg functions.
>>
>> Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
> 
> I think this should be a platform driver in drivers/power/reset.

Yeah, I thought that too, see my cover letter. The problem is, in that
module are also some register which are of interest when implementing
suspend/resume support (see cover letter too). However, we could also
just make a dt entry for that reset register only, and create another dt
entry for the other registers.

> If the SRC is also capable of resetting individual blocks instead of just
> the entire machine, it would be a reset driver in drivers/reset instead.

Beside the system reset, there is only a mask functionality for the
watchdogs (there are two watchdogs, one for Cortex-A5 and one for the
M4). This makes the SRC module in the Vybrid a bit different then what
is available on other i.MX SoC's...

--
Stefan

> 
> 	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/