Re: [Update][PATCH] USB / PM: Drop CONFIG_PM_RUNTIME from the USB core

[Rafael J. Wysocki]

On Friday, November 28, 2014 11:09:11 AM Alan Stern wrote:
> On Fri, 28 Nov 2014, Rafael J. Wysocki wrote:
> 
> > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > Subject: USB / PM: Drop CONFIG_PM_RUNTIME from the USB core
> > 
> > After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is
> > selected) PM_RUNTIME is always set if PM is set, so quite a few
> > #ifdef blocks depending on CONFIG_PM_RUNTIME may now be changed to
> > depend on CONFIG_PM (or even dropped in some cases).
> > 
> > Replace CONFIG_PM_RUNTIME with CONFIG_PM in the USB core code
> > and ABI documentation.
> > 
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > ---
> > 
> > Added headers and two ABI documentation files, plus one missing instance in
> > drivers/usb/core/hcd.c.
> > 
> > Of course, this depends on commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME
> > if PM_SLEEP is selected) which is in linux-next only (via linux-pm) at the
> > moment.
> 
> There are also one or two places in Documentation/usb that mention 
> CONFIG_PM_RUNTIME.

I found this in Documentation/usb/power-management.txt:

"Note: Dynamic PM support for USB is present only if the kernel was
 built with CONFIG_USB_SUSPEND enabled (which depends on
 CONFIG_PM_RUNTIME).  System PM support is present only if the kernel
 was built with CONFIG_SUSPEND or CONFIG_HIBERNATION enabled.

 (Starting with the 3.10 kernel release, dynamic PM support for USB is
 present whenever the kernel was built with CONFIG_PM_RUNTIME enabled.
 The CONFIG_USB_SUSPEND option has been eliminated.)"

but I'm quite unsure how to change it.  What about:

"System PM support is present only if the kernel was built with CONFIG_SUSPEND
 or CONFIG_HIBERNATION enabled.  Dynamic PM support for USB is present whenever
 the kernel was built with CONFIG_PM enabled.

 [Historically, dynamic PM support for USB was present only if the kernel
 had been built with CONFIG_USB_SUSPEND enabled (which depended on
 CONFIG_PM_RUNTIME).  Starting with the 3.10 kernel release, dynamic PM support
 for USB was present whenever the kernel was built with CONFIG_PM_RUNTIME
 enabled.  The CONFIG_USB_SUSPEND option had been eliminated.]

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/