Re: [patch v2] adjtimex.2: add explanation about ADJ_TAI action

[Laurent Georget]

Hello,

Le 29/11/2014 10:27, Michael Kerrisk (man-pages) a écrit :
> Hello Laurent,
> 
> Thanks for working on this. I have one question; see below.
> 
>>
>> diff --git a/man2/adjtimex.2 b/man2/adjtimex.2
>> index 20a2f0b..871e607 100644
>> --- a/man2/adjtimex.2
>> +++ b/man2/adjtimex.2
>> @@ -26,9 +26,6 @@
>>  .\" Modified 2004-05-27 by Michael Kerrisk <mtk.manpages@xxxxxxxxx>
>>  .\" Modified 2014-11-28 by Laurent Georget <laurent.georget@xxxxxxxxxx>
>>  .\"
>> -.\" FIXME Document ADJ_TAI (added in Linux 2.6.26)
>> -.\"		commit 153b5d054ac2d98ea0d86504884326b6777f683d
>> -.\"
>>  .\" FIXME Document ADJ_MICRO and ADJ_NANO (added in Linux 2.6.26)
>>  .\"		commit eea83d896e318bda54be2d2770d2c5d6668d11db
>>  .\"		Author: Roman Zippel <zippel@xxxxxxxxxxxxxx>
>> @@ -74,6 +71,17 @@ struct timex {
>>                              (read-only) */
>>      struct timeval time; /* current time (read-only) */
>>      long tick;           /* usecs between clock ticks */
> 
> What is the following piece about? Did you mean to include it in this patch?

Those are new fields added in struct timex since the last edition of the
man page. Maybe I should split the commit in two subcommits: the first
one to add the new fields, and the second one to specifically add the
ADJ_TAI flag?

> 
>> +
>> +    long ppsfreq;        /* pps frequency (scaled ppm) (read-only) */
>> +    long jitter;         /* pps jitter (usec) (read-only) */
>> +    int shift;           /* interval duration (sec) (read-only) */
>> +    long stabil;         /* pps stability (scaled ppm) (read-only) */
>> +    long jitcnt;         /* jitter limit exceeded (read-only) */
>> +    long calcnt;         /* calibration intervals (read-only) */
>> +    long errcnt;         /* calibration errors (read-only) */
>> +    long stbcnt;         /* stability limit exceeded (read-only) */
>> +
>> +    int tai;             /* TAI offset (s) (read-only) */
>>  };
> 
> Thanks,
> 
> Michael
> 

Thanks,

Laurent

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/