Re: [PATCH] Fixed type id

From: Richard Weinberger
Date: Sat Nov 29 2014 - 05:26:25 EST


On Sat, Nov 29, 2014 at 11:13 AM, Ren Kimura <rkx1209@xxxxxxxxx> wrote:
> From: RKX1209 <rkx1209@xxxxxxxxx>
>
> Signed-off-by: RKX1209 <rkx1209@xxxxxxxxx>

What issue does this fix?
On 32bit an address should fit into an integer.

> ---
> arch/x86/mm/init_32.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
> index c8140e1..957f7f0 100644
> --- a/arch/x86/mm/init_32.c
> +++ b/arch/x86/mm/init_32.c
> @@ -304,14 +304,14 @@ repeat:
> #endif
> for (; pmd_idx < PTRS_PER_PMD && pfn < end_pfn;
> pmd++, pmd_idx++) {
> - unsigned int addr = pfn * PAGE_SIZE + PAGE_OFFSET;
> + unsigned long addr = pfn * PAGE_SIZE + PAGE_OFFSET;
>
> /*
> * Map with big pages if possible, otherwise
> * create normal page tables:
> */
> if (use_pse) {
> - unsigned int addr2;
> + unsigned long addr2;
> pgprot_t prot = PAGE_KERNEL_LARGE;
> /*
> * first pass will use the same initial
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/



--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/