Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

[LoÃc Pefferkorn]

On Fri, Nov 28, 2014 at 02:22:07PM -0800, Greg KH wrote:
> 
> That's even worse than I imagined.  Putting sparse markings on these
> function calls is just papering over nonsense.  Please work on unwinding
> the mess so that you don't need callbacks for locks, that is an
> abstraction that isn't needed.
> 
> Same here, ick ick ick.
> 
> 
> Don't hide "implementation of locks" in functions like this, it only
> causes problems.  This code has layers of layers of layers of
> abstractions due to it wanting to be originally ported to other
> operating systems and lots of different kernel versions of Linux itself.
> Unwinding and removing those layers is a good thing to do, don't paper
> over the nonsense by putting sparse markings on pointless functions.
> 
> thanks,

Hi guys,

Thanks for your reply. I'm going to write a v2.

-- 
Cheers,
LoÃc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/