RE: [PATCH urgent v2] sched: Add missing rcu protection to wake_up_all_idle_cpus

From: Liu, Chuansheng
Date: Sun Nov 30 2014 - 22:13:45 EST




> -----Original Message-----
> From: Andy Lutomirski [mailto:luto@xxxxxxxxxxxxxx]
> Sent: Sunday, November 30, 2014 12:14 AM
> To: Ingo Molnar; Thomas Gleixner; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Peter Zijlstra; Andy Lutomirski; Liu, Chuansheng
> Subject: [PATCH urgent v2] sched: Add missing rcu protection to
> wake_up_all_idle_cpus
>
> Locklessly doing is_idle_task(rq->curr) is only okay because of RCU
> protection. The older variant of the broken code checked
> rq->curr == rq->idle instead and therefore didn't need RCU.
>
> Fixes: f6be8af1c95d sched: Add new API wake_up_if_idle() to wake up the idle
> cpu
> Cc: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> ---
Reviewed-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>

Thanks Andy.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/