Re: [PATCH 6/20] TTY: fix misspelling of current function in string

From: Jiri Slaby
Date: Mon Dec 08 2014 - 03:49:10 EST


On 12/07/2014, 08:20 PM, Julia Lawall wrote:
> Replace the last argument of serial_paranoia_check by the actual function
> name.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> ---
> The semantic patch is difficult to summarize, but is available in the cover
> letter of this patch series.
>
> drivers/tty/amiserial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index d9f85f9..b2d7600 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -931,7 +931,7 @@ static void rs_send_xchar(struct tty_struct *tty, char ch)
> struct serial_state *info = tty->driver_data;
> unsigned long flags;
>
> - if (serial_paranoia_check(info, tty->name, "rs_send_char"))
> + if (serial_paranoia_check(info, tty->name, "rs_send_xchar"))

I wonder, why not to use __func__ here too?

thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/