Re: nokia_h4p on 3.16+

From: Pali RohÃr
Date: Mon Dec 08 2014 - 17:10:59 EST


On Monday 08 December 2014 21:47:35 Pavel Machek wrote:
> Hi!
>
> It seems commit:
>
> commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b
> Author: Felipe Balbi <balbi@xxxxxx>
> Date: Wed Apr 23 09:58:28 2014 -0500
>
> serial: fix UART_IIR_ID
>
> UART IRQ Identification bitfield is 3
> bits long (bits 3:1) but current mask only
> masks 2 bits. Fix it.
>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).
>
> Pali, you may want to revert the patch.
>
> That is good news, because reverting it on 3.18-rcX brings h4p
> back, too (and as machine boots on nfsroot, debugging should
> be possible.)
>
> Best regards,
> Pavel

Pavel, maybe there is some unhandled iir value in function
static irqreturn_t hci_h4p_interrupt(int irq, void *data)
which cause that driver is not working?

--
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.