Re: [PATCH 1/2] regulator: rk808: add dvs support

[Doug Anderson]

Chris,

On Tue, Dec 9, 2014 at 5:51 AM, Chris Zhong <zyw@xxxxxxxxxxxxxx> wrote:
> +       /* dvsok pin would be pull down when dvs1/2 pin changed, and
> +        * it would be pull up once the voltage regulate complete.
> +        * No need to wait dvsok signal when voltage falling.
> +        */

A tiny nit that I think standard multiline commenting style should
make the above:

+       /*
+        * dvsok pin would be pull down when dvs1/2 pin changed, and
+        * it would be pull up once the voltage regulate complete.
+        * No need to wait dvsok signal when voltage falling.
+        */

...but I'll leave it up to broonie@ if he cares...

Given that I've privately reviewed an earlier version of this before
you sent it up, it's not surprising that I have no other comments, so:

Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>

:)

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/