Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

[Jacek Anaszewski]

Hi Sakari,

On 12/04/2014 12:40 PM, Jacek Anaszewski wrote:

> On 12/04/2014 11:07 AM, Sakari Ailus wrote:
> > Hi Jacek,
> >
> > On Wed, Dec 03, 2014 at 05:06:41PM +0100, Jacek Anaszewski wrote:
> > > This patch adds device tree binding documentation for
> > > the flash cell of the Maxim max77693 multifunctional device.
> > >
> > > Signed-off-by: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx>
> > > Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> > > Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> > > Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> > > Cc: Bryan Wu <cooloney@xxxxxxxxx>
> > > Cc: Richard Purdie <rpurdie@xxxxxxxxx>
> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > > Cc: Pawel Moll <pawel.moll@xxxxxxx>
> > > Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > > Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
> > > Cc: Kumar Gala <galak@xxxxxxxxxxxxxx>
> > > Cc: <devicetree@xxxxxxxxxxxxxxx>
> > > ---
> > >   Documentation/devicetree/bindings/mfd/max77693.txt |   89
> > > ++++++++++++++++++++
> > >   1 file changed, 89 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt
> > > b/Documentation/devicetree/bindings/mfd/max77693.txt
> > > index 01e9f30..25a6e78 100644
> > > --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> > > +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> > > @@ -41,7 +41,66 @@ Optional properties:
> > >        To get more informations, please refer to documentaion.
> > >       [*] refer Documentation/devicetree/bindings/pwm/pwm.txt
> > >
> > > +- led : the LED submodule device node
> > > +
> > > +There are two led outputs available - fled1 and fled2. Each of them can
> > > +control a separate led or they can be connected together to double
> > > +the maximum current for a single connected led. One led is represented
> > > +by one child node.
> > > +
> > > +Required properties:
> > > +- compatible : Must be "maxim,max77693-led".
> > > +
> > > +Optional properties:
> > > +- maxim,fleds : Array of current outputs in order: fled1, fled2.
> > > +    Note: both current outputs can be connected to a single led
> > > +    Possible values:
> > > +        MAX77693_LED_FLED_UNUSED - the output is left disconnected,
> > > +        MAX77693_LED_FLED_USED - a diode is connected to the output.
> >
> > As you have a LED sub-nodes for each LED already, isn't this redundant?
>
> Well, it seems so :)

I agreed here recklessly. This property allows to describe the
situation when one LED is connected to both outputs. Single sub-node
can describe two type of designs: one LED connected to a single
output or one LED connected to both outputs. Therefore additional
property is needed to assess what is the actual case.

Best Regards,
Jacek Anaszewski

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/