Re: [PATCH v3 2/4] gpio/xilinx: Convert the driver to platform device interface

[Ricardo Ribalda Delgado]

>
> Still not correct.
Not my day.

> Here should be module_exit if you want to use as module.
> I expect that you haven't tested it.


No, I only tried the original patchset, I assumed this was just
cosmetic changes ;)

Right now I have tested it  :P

 to attach helpers instead.
[  199.175954] XGpio: /axi1/gpio_0: registered, base is 509
[  242.362202] gpio-xilinx 80040000.gpio_0: REMOVING GPIOCHIP WITH
GPIOS STILL REQUESTED
[  242.362218] gpio-xilinx 80040000.gpio_0: REMOVING GPIOCHIP WITH
GPIOS STILL REQUESTED
[  242.362222] gpio-xilinx 80040000.gpio_0: REMOVING GPIOCHIP WITH
GPIOS STILL REQUESTED


I am resending only this patch to avoid spamming the list


>
> Thanks,

Thank you!


> Michal
>
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/