Re: [PATCH v4 2/6] arm: dts: socfpga: add altera fpga manager

[Steffen Trumtrar]

On Wed, Dec 10, 2014 at 11:25:59AM -0600, atull wrote:
> On Wed, 10 Dec 2014, Steffen Trumtrar wrote:
> 
> > Hi!
> > 
> > On Tue, Dec 09, 2014 at 02:14:46PM -0600, atull@xxxxxxxxxxxxxxxxxxxxx wrote:
> > > From: Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx>
> > > 
> > > Add Altera FGPA manager to device tree.
> > > 
> > > Signed-off-by: Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx>
> > > ---
> > >  arch/arm/boot/dts/socfpga.dtsi |   10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > > index 4472fd9..bab98b6 100644
> > > --- a/arch/arm/boot/dts/socfpga.dtsi
> > > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > > @@ -751,5 +751,15 @@
> > >  			compatible = "altr,sys-mgr", "syscon";
> > >  			reg = <0xffd08000 0x4000>;
> > >  		};
> > > +
> > > +		hps_0_fpgamgr: fpgamgr@0xff706000 {
> > > +			compatible = "altr,fpga-mgr", "simple-bus";
> > > +			reg = <0xFF706000 0x1000
> > > +			       0xFFB90000 0x1000>;
> > > +			interrupts = <0 175 4>;
> > > +			#address-cells = <1>;
> > > +			#size-cells = <1>;
> > > +			ranges;
> > > +		};
> > 
> > The fpgamgr is NOT a bus. You don't need ranges and/or simple-bus.
> > 
> > Regards,
> > Steffen
> 
> Actually, I am going to be using this when I add the DT notification 
> stuff.  That stuff is waiting for DT overlays to show up in the main
> tree.
> 
> So the choice it to either change this file now, once, or do the minimal 
> changes and have to change it again later.
> 

Yes, that is what I thought. And still, devices can NOT show up
at the fpgamgr. They show up on the various bridges.

And as far as I understand the DT overlay stuff, you specify in
the overlay what the parent node will be.
For i2c this is one of the i2c-hosts, for spi one of the spi-hosts
and for IP cores in a bitstream one of the bridges.

The fpgamgr is, from my understanding, only responsible for writing
the bitstream to the FPGA; nothing more.

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/