Re: [PATCH 2/4] powerpc32: properly clear page table when 0 is not a good default PTE value

[Scott Wood]

On Wed, 2014-12-10 at 19:00 +0100, Christophe Leroy wrote:
> Some HW invert some PTE bits. In some case, __pte(0) is not 0 so the PTEs shall
> be properly set prior to being used.

__pte(0) is always zero.  If that changes in a future patch, that patch
is not doing the right thing.  The __pte()/pte_val() accesors should not
do anything beyond boxing/unboxing the value in a struct.  The right
place for special 8xx handling of the inverted bit is in pte_mkwrite()
and such.

I don't see any other architecture using __pte()/pte_val() this way.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/