Re: [tip:x86/apic] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c

[Yinghai Lu]

On Wed, Dec 10, 2014 at 12:15 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Tue, 9 Dec 2014, Yinghai Lu wrote:
>
> Can you please
>
> 1) Cut out the completely irrelevant information from your replies?
>    It's just annoying to scroll through hundreds of quoted lines to
>    find the guts of the mail.

ok.

>
> 2) Send patches inline. It's a pain to review and reply and I can't
>    use my normal tooling.

I can not, as gmail does not allow that.


>>
>> Attached patch should address them.
>
>> -       struct resource r = {
>> -               .flags = 0
>> -       };
>> +       struct resource r;
>>
>> +       memset(&r, 0, sizeof(r));
>
> What's the point of this change? Both initialize r to 0. memset()
> generates better code, but that's irrelevant for the problem at hand.

late there is

info->res[info->res_num] = r;

don't want the random pointer in r get copied.

>
>> Please fix it before it get into linus tree.
>
> You can be sure that I'm going to fix the whole mess there proper and
> not by applying a cobbled together bandaid.

Good.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/