Re: [PATCH] xen: switch to post-init routines in xen mmu.c earlier

[Juergen Gross]

On 12/10/2014 05:13 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Dec 10, 2014 at 04:56:03PM +0100, Juergen Gross wrote:
> > With the virtual mapped linear p2m list the post-init mmu operations
> > must be used for setting up the p2m mappings, as in case of
> > CONFIG_FLATMEM the init routines may trigger BUGs.
>
> Um, could you explain a bit more of why the CONFIG_FLATMEM
> is such unique? What about the other CONFIG_*MEM cases?

CONFIG_FLATMEM is just the configuration hitting a BUG() in
xen_alloc_pte_init() being used after finishing paging_init().

Juergen

> > Reported-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > ---
> >   arch/x86/xen/mmu.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> > index 6ab6150..a1a429a 100644
> > --- a/arch/x86/xen/mmu.c
> > +++ b/arch/x86/xen/mmu.c
> > @@ -1225,6 +1225,7 @@ static void __init xen_pagetable_p2m_setup(void)
> >   static void __init xen_pagetable_init(void)
> >   {
> >   	paging_init();
> > +	xen_post_allocator_init();
> >
> >   	xen_pagetable_p2m_setup();
> >
> > @@ -1236,7 +1237,6 @@ static void __init xen_pagetable_init(void)
> >   		xen_remap_memory();
> >
> >   	xen_setup_shared_info();
> > -	xen_post_allocator_init();
> >   }
> >   static void xen_write_cr2(unsigned long cr2)
> >   {
> > --
> > 2.1.2
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/