Re: [PATCH] regulator: s2mps11: Fix dwmmc failure on Gear 2

[Krzysztof Kozlowski]

On czw, 2014-12-11 at 13:13 +0000, Mark Brown wrote:
> On Thu, Dec 11, 2014 at 01:39:11PM +0100, Krzysztof Kozlowski wrote:
> > Invalid buck4 configuration in S2MPS14 regulators caused boot failure on
> > Gear 2 (dwmmc_exynos):
> 
> What is invalid about the configuration and how is this change intended
> to fix it?

Wrong number was used for buck4 linear_min_sel. It should be
S2MPS14_BUCK4_START_SEL (0x40) instead of S2MPS14_BUCK1235_START_SEL
(0x20).

Issue is fixed by using proper number.

I'll resend the patch with extended description.

> 
> > [    3.569137] EXT4-fs (mmcblk0p15): mounted filesystem with ordered data mode. Opts: (null)
> > [    3.571716] VFS: Mounted root (ext4 filesystem) readonly on device 179:15.
> > [    3.580836] devtmpfs: mounted
> > [    3.582033] Freeing unused kernel memory: 284K (c05b4000 - c05fb000)
> > [    3.629842] mmcblk0: error -110 sending status command, retrying
> > [    3.630244] mmcblk0: error -110 sending status command, retrying
> 
> Please don't include large log sections in commit messages, edit them
> down to any relevant information.  They get very large and obscure the
> relevant content in the messages.

I'll trim it.

Best regards,
Krzysztof



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/