Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

From: Linus Torvalds
Date: Thu Dec 11 2014 - 21:29:45 EST


On Thu, Dec 11, 2014 at 6:12 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> Linus, do you see any problems with the following patch (against the mainline)?

Not concpetually, but create_kthread() uses CLONE_FS, and I don't
think it's just umask that things like nfsd want to avoid sharing.
What about all the *other* fields?

Just as an example: even if all the threads actually end up all having
the same global root, what about contention on 'fs->lock'?

I have *not* looked at the details, and maybe there's some reason I'm
completely off, but it worries me.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/