Re: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static

[atull]

On Thu, 11 Dec 2014, One Thousand Gnomes wrote:

> On Thu, 11 Dec 2014 09:43:24 +0800
> kbuild test robot <fengguang.wu@xxxxxxxxx> wrote:
> 
> > drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> 
> Ought to be const as well by the look of it - we don't want function
> pointers in patchable memory spaces.
> 

I agree.  Will be in v5.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/