Re: [PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions

From: Jarkko Sakkinen
Date: Sun Dec 14 2014 - 10:42:41 EST


On Sun, Dec 14, 2014 at 04:31:10PM +0100, peterhuewe@xxxxxx wrote:
>
>
> On 14. Dezember 2014 15:57:10 MEZ, Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote:
> >On Sun, 2014-12-14 at 09:03 -0500, Stefan Berger wrote:
> >> On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote:
> >> > Merged transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c.
> >> > Added "tpm_" prefix for consistency sake. Changed cmd parameter as
> >> > opaque. This enables to use separate command structures for TPM1
> >> > and TPM2 commands in future. Loose coupling works fine here.
> >> >
> >> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> >> > Reviewed-by: Jasob Gunthorpe <jason.gunthorpe@xxxxxxxxxxxxxxxxxxxx>
> >> > Reviewed-by: Stephan Berger <stephan.berger@xxxxxxxxxxxxxxxxxx>
> >>
> >> Not quite ... Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>
> >
> >Oops. Peter, I guess you could fix those or? My apologies.
> >
> >> Stefan
> >
> >/Jarkko
> I'll fix this,
> No problem.

Thank you.

> Peter

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/