Re: [v4,4/4] powernv: powerpc: Add winkle support for offline cpus

[Michael Ellerman]

On Sun, 2014-12-14 at 17:22 +0530, Shreyas B Prabhu wrote:
> On Sunday 14 December 2014 03:35 PM, Michael Ellerman wrote:
> >> diff --git a/arch/powerpc/platforms/powernv/subcore.h b/arch/powerpc/platforms/powernv/subcore.h
> >> index 148abc9..604eb40 100644
> >> --- a/arch/powerpc/platforms/powernv/subcore.h
> >> +++ b/arch/powerpc/platforms/powernv/subcore.h
> >> @@ -15,4 +15,5 @@
> >>  
> >>  #ifndef __ASSEMBLY__
> >>  void split_core_secondary_loop(u8 *state);
> >> +extern void update_subcore_sibling_mask(void);
> >>  #endif
> > 
> > subcore.c isn't built for CONFIG_SMP=n, resulting in:
> > 
> >   setup.c:(.init.text+0x34b0): undefined reference to `.update_subcore_sibling_mask'
> > 
> > I needed to add:
> > 
> > +#else
> > +static inline void update_subcore_sibling_mask(void) { };
> > +#endif /* CONFIG_SMP */

> Sorry I missed that.

No worries.

Can you please do a quick test with a SMP=n kernel.

It looks like it should work, but it would be good to test.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/