Re: [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c

[Jens Axboe]

On 12/14/2014 07:46 PM, nick wrote:
> Jens,
> After rechecking the function definition we can't return an error as add_disk is declared void. Should I change the function to an int and then return an error. My thinking was that there is no good way to return an error code without
> a breakage in the functions that  call add_disk.

Please don't top post...

It's a big job, it requires properly checking and updating all block 
drivers. But yes, that is what would be required in removing that TODO.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/