Re: [PATCH 3.18 15/19] move d_rcu from overlapping d_child to overlapping d_alias

[Josh Boyer]

On Mon, Dec 15, 2014 at 4:34 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Dec 15, 2014 at 04:21:12PM -0500, Josh Boyer wrote:
>> On Mon, Dec 15, 2014 at 11:38 AM, Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx> wrote:
>> > On Mon, Dec 15, 2014 at 11:34 AM, Greg Kroah-Hartman
>> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> >> On Mon, Dec 15, 2014 at 10:46:50AM -0500, Josh Boyer wrote:
>> >>> On Sun, Dec 14, 2014 at 12:21:26PM -0800, Greg Kroah-Hartman wrote:
>> >>> >3.18-stable review patch.  If anyone has any objections, please let me know.
>> >>> >
>> >>> >------------------
>> >>> >
>> >>> >From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
>> >>> >
>> >>> >commit 946e51f2bf37f1656916eb75bd0742ba33983c28 upstream.
>> >>> >
>> >>> >Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
>> >>> >Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> >>>
>> >>> I noticed you don't have this (and the child commit) queued for 3.17.y.
>> >>
>> >> That is because:
>> >>
>> >>> The backport wasn't exactly straight-forward because of the d_external
>> >>> stuff, but I took a swing at it.  After that, the other commit was a
>> >>> quick cherry-pick.
>> >>
>> >> It wasn't a "simple" backport, and I didn't have the time.  I'm also
>> >> going to drop 3.17 real-soon-now.
>> >
>> > Right, figured.  Fedora isn't going to rebase the stable releases to
>> > 3.18 until 3.18.2-ish, and this fixes an issue so I thought I'd give
>> > it a try.
>> >
>> >>> Al, does the below look correct for a backport on top of 3.17.6?  It
>> >>> builds, but I haven't tested it yet.
>> >>
>> >> Testing would be great to do :)
>> >
>> > Working on it.  Just wanted to send it out early in case Al spotted
>> > something obviously wrong and wanted to yell at me for it.
>>
>> Finally got around to booting it.  Something is definitely wrong.  Sigh.
>
> Start with moving WARN_ON() into dentry_free() (as it's done in mainline and
> for the same reason)...

Gah, yes.  I'd just gotten to that hunk and realized it looked really
really wrong.  I'll give that a shot.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/