Re: [PATCH] cpufreq-dt: defer probing if OPP table is not ready

[Dmitry Torokhov]

On Mon, Dec 15, 2014 at 9:38 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 16 December 2014 at 11:02, Dmitry Torokhov <dtor@xxxxxxxxxxxx> wrote:
>> Yes we will. Which simply means that this WARN is stupid. We also will
>> hit it if there is no opp table and the allocation below fails; or if
>> it succeeds then dev_pm_opp_init_cpufreq_table() will fail and we'll
>> hit this code path again.
>>
>> We should either drop that WARN() or handle -ENODEV there properly.
>
> Yeah, we should drop it. Its just too hard for such cases. You will take care
> of that in your series?
>

Yes, I'll address other comments and resubmit.

> For your patch:
>
> Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Thanks!

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/