Re: [Xen-devel] [PATCH 4/4] xen: use generated hypercall symbols in arch/x86/xen/xen-head.S

[Juergen Gross]

On 12/15/2014 01:05 PM, David Vrabel wrote:
> On 11/12/14 18:04, Juergen Gross wrote:
> > Instead of manually list each hypercall in arch/x86/xen/xen-head.S
> > use the auto generated symbol list.
> >
> > This also corrects the wrong address of xen_hypercall_mca which was
> > located 32 bytes higher than it should.
> >
> > Symbol addresses have been verified to match the correct ones via
> > objdump output.
> [...]
> > +
> > +#define HYPERCALL(n) \
> > +	.equ xen_hypercall_##n, hypercall_page + __HYPERVISOR_##n * 32; \
> > +	.type xen_hypercall_##n, function; .size xen_hypercall_##n, 32
> > +#include <asm/xen-hypercalls.h>
> > +#undef HYPERCALL
>
> The gas manual[1] suggests the syntax you've used for .type is invalid
> and suggest using .type <name>, STT_FUNC

Really? In the link below I see:

The types supported are:

STT_FUNC
function
    Mark the symbol as being a function name.
...

So "function" seems to be okay.

> > +
> >   	.balign PAGE_SIZE
>
> You can remove this .balign.

Indeed.


Juergen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/