Re: [PATCH v10] iopoll: Introduce memory-mapped IO polling macros

[Will Deacon]

On Mon, Dec 15, 2014 at 11:47:23PM +0000, Mitchel Humpherys wrote:
> From: Matt Wagantall <mattw@xxxxxxxxxxxxxx>
> 
> It is sometimes necessary to poll a memory-mapped register until its value
> satisfies some condition. Introduce a family of convenience macros that do
> this. Tight-looping, sleeping, and timing out can all be accomplished using
> these macros.
> 
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Robert Elliott <elliott@xxxxxx>
> Signed-off-by: Matt Wagantall <mattw@xxxxxxxxxxxxxx>
> Signed-off-by: Mitchel Humpherys <mitchelh@xxxxxxxxxxxxxx>
> ---
> v9..10:
>   - Actually added the comments mentioned in v8..v9 (doh!)
> 
> v8..v9:
>   - Added note in comments about max sleep time (Rob Elliott)
> 
> v7..v8:
>   - sorted helper macros by size (b, w, l, q)
>   - removed some of the more esoteric (or flat-out bogus) helper macros
> 
> This patch was originally part of a series [1] for adding support for IOMMU
> address translations through an ARM SMMU hardware register.  The other
> patch in the series (the one that actually uses these macros and implements
> said hardware address translations) was Ack'd by the driver maintainer
> there (Will Deacon) so I've pulled this patch out to avoid resending an
> already Ack'd patch over and over again.
> 
> In short, please see [1] for previous discussion and the first user of
> these macros.
> 
> Will also acked this patch in [2].  I didn't retain his Ack here because I
> added to the macro comments.

You can keep the ack, it still looks good to me and I'm not really fussed
about the comments.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/